Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grep): references to cypress-grep #26108

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

jordanpowell88
Copy link
Contributor

Additional details

fix references still pointing to cypress-grep

Steps to test

How has the user experience changed?

PR Tasks

@jordanpowell88 jordanpowell88 requested a review from a team March 14, 2023 17:39
@jordanpowell88
Copy link
Contributor Author

Reopening a simplified version of this PR without tests (as the tests were blocking the original PR)

npm/grep/README.md Outdated Show resolved Hide resolved
@@ -228,7 +228,7 @@ if (!Cypress.grep) {
* // remove all current grep settings
* // and run all tests
* Cypress.grep()
* @see "Grep from DevTools console" https://github.com/cypress-io/cypress-grep#devtools-console
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

system-tests/projects/nx-monorepo was this file added on accident?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@jordanpowell88 jordanpowell88 force-pushed the jordanpowell88/cypress-grep branch from a74aebd to c5c318f Compare March 14, 2023 17:50
Co-authored-by: Emily Rohrbough <[email protected]>
@cypress
Copy link

cypress bot commented Mar 14, 2023

28 flaky tests on run #44752 ↗︎

0 26889 1281 0 Flakiness 28

Details:

Update npm/grep/README.md
Project: cypress Commit: f249865c69
Status: Passed Duration: 19:47 💡
Started: Mar 14, 2023 6:01 PM Ended: Mar 14, 2023 6:20 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output
Flakiness  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
cy.origin assertions > #consoleProps > .should() and .and() Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
Flakiness  create-from-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
... > runs generated spec Output Screenshots Video

The first 5 flaky specs are shown, see all 17 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jordanpowell88 jordanpowell88 merged commit 7a18b79 into develop Mar 15, 2023
@jordanpowell88 jordanpowell88 deleted the jordanpowell88/cypress-grep branch March 15, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants